Comments for Eventlet http://blog.eventlet.net A better way to write network applications Thu, 05 Aug 2010 07:00:13 +0000 hourly 1 http://wordpress.com/ Comment on Websocket Draft 76 by Ryan Williams http://blog.eventlet.net/2010/06/15/websocket-draft-76/#comment-57 Ryan Williams Thu, 05 Aug 2010 07:00:13 +0000 http://blog.eventlet.net/?p=132#comment-57 Ben, I apologize for my late reply. There is something seriously wrong with Wordpress's email notifications (or I am super-dumb). >:( I absolutely support refactoring this code outside of the class. I kinda started to do that myself but didn't finish. The handshake code you have there looks supa-clean. Ben, I apologize for my late reply. There is something seriously wrong with WordPress’s email notifications (or I am super-dumb). >:(

I absolutely support refactoring this code outside of the class. I kinda started to do that myself but didn’t finish. The handshake code you have there looks supa-clean.

]]> Comment on Websocket Draft 76 by Ben http://blog.eventlet.net/2010/06/15/websocket-draft-76/#comment-46 Ben Tue, 15 Jun 2010 05:58:44 +0000 http://blog.eventlet.net/?p=132#comment-46 Hey Ryan, This is great! Saves some work for me :-) One request though: As I and probably a lot of other people will be using websockets in a web framework of some description, do you mind if I have a tinker with this and make it standalone outside of the WebSocketWSGI class? What did you think of this code I showed you a couple of weeks ago as an API? http://github.com/boothead/rpz.websocket/blob/master/rpz/websocket/handshake.py Cheers, Ben Hey Ryan,

This is great! Saves some work for me :-)

One request though: As I and probably a lot of other people will be using websockets in a web framework of some description, do you mind if I have a tinker with this and make it standalone outside of the WebSocketWSGI class?

What did you think of this code I showed you a couple of weeks ago as an API?
http://github.com/boothead/rpz.websocket/blob/master/rpz/websocket/handshake.py

Cheers,
Ben

]]> Comment on Changes to WSGI to Support WebSockets by Ryan Williams http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-44 Ryan Williams Fri, 07 May 2010 22:34:09 +0000 http://blog.eventlet.net/?p=65#comment-44 Yeah, those were failing in the <a href="http://eventlet.net/hudson/job/Eventlet%20%28trunk%29/" rel="nofollow">continuous build</a> already. Check that link out if you haven't seen it already. I fixed those failures the other day, so you should be good to go. Thanks for the changes, glad to have a serious complement of tests! Yeah, those were failing in the continuous build already. Check that link out if you haven’t seen it already. I fixed those failures the other day, so you should be good to go.

Thanks for the changes, glad to have a serious complement of tests!

]]> Comment on Scalable, WSGI-compatible Websockets by Ryan Williams http://blog.eventlet.net/2010/02/12/scalable-wsgi-compatible-websockets/#comment-43 Ryan Williams Fri, 07 May 2010 22:30:06 +0000 http://blog.eventlet.net/?p=56#comment-43 That's odd -- WebSocketWSGI was always defined in the file itself, so it's weird that it wouldn't be able to find a definition that's right above it. Nevertheless, Ben Ford and I have pulled the websocket support into the core of Eventlet now, and it certainly works. Please give it a shot again, and let me know if you have trouble with it. That’s odd — WebSocketWSGI was always defined in the file itself, so it’s weird that it wouldn’t be able to find a definition that’s right above it. Nevertheless, Ben Ford and I have pulled the websocket support into the core of Eventlet now, and it certainly works. Please give it a shot again, and let me know if you have trouble with it.

]]> Comment on Changes to WSGI to Support WebSockets by Ben http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-42 Ben Thu, 06 May 2010 04:26:46 +0000 http://blog.eventlet.net/?p=65#comment-42 Hi Ryan, I've made some more changes: Added eventlet.websocket which is the WebSocket object in examples/websocket with some of my changes. Added my modified tests from the repoze project I was working on for 100% test coverage for the websocket stuff. I think my last set of changes re ALREADY_HANDLED may have been incomplete, so added a little diff that I missed. I have a couple of failing tests under OSX: ====================================================================== FAIL: test_cancel_accumulated (tests.hub_test.TestTimerCleanup) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/benford/pycharm/eventlet/tests/hub_test.py", line 19, in test_cancel_accumulated self.assert_(hub.timers_cancelled < len(hub.timers)) AssertionError ====================================================================== FAIL: test_cancel_proportion (tests.hub_test.TestTimerCleanup) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/benford/pycharm/eventlet/tests/hub_test.py", line 39, in test_cancel_proportion self.assert_(hub.timers_cancelled < len(hub.timers)) AssertionError (these were failing before my changes) have you seen these before? Cheers, Ben P.S. I think I sent you a real pull request this time :-) Hi Ryan,

I’ve made some more changes:

Added eventlet.websocket which is the WebSocket object in examples/websocket with some of my changes.
Added my modified tests from the repoze project I was working on for 100% test coverage for the websocket stuff.
I think my last set of changes re ALREADY_HANDLED may have been incomplete, so added a little diff that I missed.

I have a couple of failing tests under OSX:

======================================================================
FAIL: test_cancel_accumulated (tests.hub_test.TestTimerCleanup)
———————————————————————-
Traceback (most recent call last):
File “/Users/benford/pycharm/eventlet/tests/hub_test.py”, line 19, in test_cancel_accumulated
self.assert_(hub.timers_cancelled < len(hub.timers))
AssertionError

======================================================================
FAIL: test_cancel_proportion (tests.hub_test.TestTimerCleanup)
———————————————————————-
Traceback (most recent call last):
File "/Users/benford/pycharm/eventlet/tests/hub_test.py", line 39, in test_cancel_proportion
self.assert_(hub.timers_cancelled < len(hub.timers))
AssertionError

(these were failing before my changes) have you seen these before?

Cheers,
Ben
P.S. I think I sent you a real pull request this time :-)

]]> Comment on Scalable, WSGI-compatible Websockets by manatlan http://blog.eventlet.net/2010/02/12/scalable-wsgi-compatible-websockets/#comment-39 manatlan Tue, 13 Apr 2010 11:11:16 +0000 http://blog.eventlet.net/?p=56#comment-39 with latest eventlet dev version (from now)... >>> NameError: name 'WebSocketWSGI' is not defined it seems it doesn't work with latest eventlet dev version (from now)…
>>> NameError: name ‘WebSocketWSGI’ is not defined

it seems it doesn’t work

]]> Comment on Changes to WSGI to Support WebSockets by Ryan Williams http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-38 Ryan Williams Sun, 11 Apr 2010 23:12:14 +0000 http://blog.eventlet.net/?p=65#comment-38 For whatever reason I didn't get the pull request; however I saw the changes in your repo and pulled them. Let me know when you've got more tests! For whatever reason I didn’t get the pull request; however I saw the changes in your repo and pulled them. Let me know when you’ve got more tests!

]]> Comment on Changes to WSGI to Support WebSockets by Ben http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-35 Ben Fri, 09 Apr 2010 06:25:15 +0000 http://blog.eventlet.net/?p=65#comment-35 I've made some initial changes and submitted a pull request on bitbucket Ben I’ve made some initial changes and submitted a pull request on bitbucket

Ben

]]> Comment on Changes to WSGI to Support WebSockets by Ryan Williams http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-34 Ryan Williams Thu, 08 Apr 2010 19:56:54 +0000 http://blog.eventlet.net/?p=65#comment-34 Yes, I'd love a patch! Thanks for thinking of this, fixing this will definitely make the websocket implementation even more wsgi-compatible! Yes, I’d love a patch! Thanks for thinking of this, fixing this will definitely make the websocket implementation even more wsgi-compatible!

]]> Comment on Changes to WSGI to Support WebSockets by Ben http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-33 Ben Thu, 08 Apr 2010 04:34:43 +0000 http://blog.eventlet.net/?p=65#comment-33 Hi, I've been busy adding websocket support to a repoze.bfg app over the last few days and have hit a little wrinkle: When you return ALREADY_HANDLED parts of your WSGI pipeline are expecting an iterable. For example if you want to use the excellent Werkzeug debuggung middleware, there's this piece of code in your upstream pipeline: try: app_iter = self.app(environ, start_response) for item in app_iter: yield item if hasattr(app_iter, 'close'): app_iter.close() ... So here when the websocket is closed on the client side you'll get an exception on the server side. There are a couple of other WSGI libraries that do this and it is a part of the WSGI api that you have a callable that returns an iterable. I've got a fork of eventlet on bitbucket would you like me to send a patch? Thanks for the great work, Ben Hi,

I’ve been busy adding websocket support to a repoze.bfg app over the last few days and have hit a little wrinkle:

When you return ALREADY_HANDLED parts of your WSGI pipeline are expecting an iterable. For example if you want to use the excellent Werkzeug debuggung middleware, there’s this piece of code in your upstream pipeline:

try:
app_iter = self.app(environ, start_response)
for item in app_iter:
yield item
if hasattr(app_iter, ‘close’):
app_iter.close()
…

So here when the websocket is closed on the client side you’ll get an exception on the server side. There are a couple of other WSGI libraries that do this and it is a part of the WSGI api that you have a callable that returns an iterable.

I’ve got a fork of eventlet on bitbucket would you like me to send a patch?

Thanks for the great work,
Ben

]]>