Comments on: Changes to WSGI to Support WebSockets http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/ A better way to write network applications Fri, 13 Jan 2012 03:30:39 +0000 hourly 1 http://wordpress.com/ By: Ryan Williams http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-44 Fri, 07 May 2010 22:34:09 +0000 http://blog.eventlet.net/?p=65#comment-44 Yeah, those were failing in the continuous build already. Check that link out if you haven’t seen it already. I fixed those failures the other day, so you should be good to go.

Thanks for the changes, glad to have a serious complement of tests!

]]> By: Ben http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-42 Thu, 06 May 2010 04:26:46 +0000 http://blog.eventlet.net/?p=65#comment-42 Hi Ryan,

I’ve made some more changes:

Added eventlet.websocket which is the WebSocket object in examples/websocket with some of my changes.
Added my modified tests from the repoze project I was working on for 100% test coverage for the websocket stuff.
I think my last set of changes re ALREADY_HANDLED may have been incomplete, so added a little diff that I missed.

I have a couple of failing tests under OSX:

======================================================================
FAIL: test_cancel_accumulated (tests.hub_test.TestTimerCleanup)
———————————————————————-
Traceback (most recent call last):
File “/Users/benford/pycharm/eventlet/tests/hub_test.py”, line 19, in test_cancel_accumulated
self.assert_(hub.timers_cancelled < len(hub.timers))
AssertionError

======================================================================
FAIL: test_cancel_proportion (tests.hub_test.TestTimerCleanup)
———————————————————————-
Traceback (most recent call last):
File "/Users/benford/pycharm/eventlet/tests/hub_test.py", line 39, in test_cancel_proportion
self.assert_(hub.timers_cancelled < len(hub.timers))
AssertionError

(these were failing before my changes) have you seen these before?

Cheers,
Ben
P.S. I think I sent you a real pull request this time :-)

]]> By: Ryan Williams http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-38 Sun, 11 Apr 2010 23:12:14 +0000 http://blog.eventlet.net/?p=65#comment-38 For whatever reason I didn’t get the pull request; however I saw the changes in your repo and pulled them. Let me know when you’ve got more tests!

]]> By: Ben http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-35 Fri, 09 Apr 2010 06:25:15 +0000 http://blog.eventlet.net/?p=65#comment-35 I’ve made some initial changes and submitted a pull request on bitbucket

Ben

]]> By: Ryan Williams http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-34 Thu, 08 Apr 2010 19:56:54 +0000 http://blog.eventlet.net/?p=65#comment-34 Yes, I’d love a patch! Thanks for thinking of this, fixing this will definitely make the websocket implementation even more wsgi-compatible!

]]> By: Ben http://blog.eventlet.net/2010/02/13/changes-to-wsgi-to-support-websockets/#comment-33 Thu, 08 Apr 2010 04:34:43 +0000 http://blog.eventlet.net/?p=65#comment-33 Hi,

I’ve been busy adding websocket support to a repoze.bfg app over the last few days and have hit a little wrinkle:

When you return ALREADY_HANDLED parts of your WSGI pipeline are expecting an iterable. For example if you want to use the excellent Werkzeug debuggung middleware, there’s this piece of code in your upstream pipeline:

try:
app_iter = self.app(environ, start_response)
for item in app_iter:
yield item
if hasattr(app_iter, ‘close’):
app_iter.close()
…

So here when the websocket is closed on the client side you’ll get an exception on the server side. There are a couple of other WSGI libraries that do this and it is a part of the WSGI api that you have a callable that returns an iterable.

I’ve got a fork of eventlet on bitbucket would you like me to send a patch?

Thanks for the great work,
Ben

]]>